Skip to content

chore: enable ruff PT006/PT007 parametrize tuple rules #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
May 20, 2026
+7 −9
Merged

chore: enable ruff PT006/PT007 parametrize tuple rules #1749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,7 @@ select = [
"SLF001",
"PLR2004", # too many to fix right now
"PT011", # too many to fix right now
"PT006", # too many to fix right now
"PGH003", # too many to fix right now
"PT007", # too many to fix right now
"PT027", # too many to fix right now
"PLW0603" , # too many to fix right now
"PLR0915", # too many to fix right now
Expand Down
12 changes: 6 additions & 6 deletions tests/utils/test_name.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ def test_service_type_name_overlong_full_name():


@pytest.mark.parametrize(
"instance_name, service_type",
(
("instance_name", "service_type"),
[
("CustomerInformationService-F4D4885E9EEB", "_ibisip_http._tcp.local."),
("DeviceManagementService_F4D4885E9EEB", "_ibisip_http._tcp.local."),
),
],
)
def test_service_type_name_non_strict_compliant_names(instance_name, service_type):
"""Test service_type_name for valid names, but not strict-compliant."""
Expand Down Expand Up @@ -62,16 +62,16 @@ def test_service_type_name_non_strict_compliant_names(instance_name, service_typ


@pytest.mark.parametrize(
"type_, expected",
(
("type_", "expected"),
[
("_http._tcp.LOCAL.", "_http._tcp.LOCAL."),
("_http._TCP.local.", "_http._TCP.local."),
("_HTTP._tcp.local.", "_HTTP._tcp.local."),
("Instance._http._tcp.LOCAL.", "_http._tcp.LOCAL."),
("_ntp._udp.LOCAL.", "_ntp._udp.LOCAL."),
("_ntp._UDP.local.", "_ntp._UDP.local."),
("Instance._ntp._udp.LOCAL.", "_ntp._udp.LOCAL."),
),
],
)
def test_service_type_name_uppercase_trailer(type_, expected):
"""RFC 1035 §2.3.3 / RFC 6762 §16 — DNS names are case-insensitive."""
Expand Down
2 changes: 1 addition & 1 deletion tests/utils/test_net.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def test_normalize_interface_choice_errors():


@pytest.mark.parametrize(
"errno,expected_result",
("errno", "expected_result"),
[
(errno.EADDRINUSE, False),
(errno.EADDRNOTAVAIL, False),
Expand Down
Loading