ci: key venv cache on resolved python patch version - #1745
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1745 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 33 33
Lines 3455 3455
Branches 478 478
=======================================
Hits 3447 3447
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the CI cache fix from #1743 so it can land on its own; the venv cache key now uses the Python version that
setup-pythonresolves, so a patch upgrade on the runner invalidates the cache instead of silently reusing stale built artifacts.Details
The cache key previously used
matrix.python-version, which is just the minor version like 3.13, so a patch upgrade on the runner kept the old cache around; switching tosteps.setup-python.outputs.python-versionpins the cache to the exact patch version that was actually installed.Test plan