test: widen LOOPBACK_FIND_TIMEOUT under PyPy#1742
Merged
Merged
Conversation
The 75ms loopback budget for ZeroconfServiceTypes.find() races PyPy's JIT warmup the first time the path runs early in the suite. Two back-to-back runs on master flaked at the same 21% point: one on test_integration_with_listener and one on test_integration_with_listener_v6_records. Bump the timeout to 300ms on PyPy only; CPython keeps the existing 75ms budget.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1742 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 33 33
Lines 3440 3440
Branches 473 473
=======================================
Hits 3432 3432
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 75ms loopback budget for
ZeroconfServiceTypes.find()races PyPy's JIT warmup the first time the path runs early in the suite; two back to back runs on master flaked at the same 21% point, once ontest_integration_with_listenerand once ontest_integration_with_listener_v6_records. Bump the timeout to 300ms on PyPy only; CPython keeps the existing 75ms budget so the fast path stays fast.Test plan
tests/services/test_types.py::test_integration_with_listener*tests