Skip to content

ci: replace per-commit conventional commits check with pr title check#1740

Merged
bdraco merged 1 commit into
masterfrom
ci/replace-commitlint-with-pr-title-check
May 19, 2026
Merged

ci: replace per-commit conventional commits check with pr title check#1740
bdraco merged 1 commit into
masterfrom
ci/replace-commitlint-with-pr-title-check

Conversation

@bdraco

@bdraco bdraco commented May 19, 2026

Copy link
Copy Markdown
Member

Summary

PRs are squash-merged, so the per-commit commitlint job and the commitizen pre-commit hook are noise; only the PR title lands on master, and the pr-title job already covers that. Drop both, configure subjectPattern on the pr-title action to keep the lowercase-first-character rule, and update the docs.

Ports Bluetooth-Devices/aiodiscover#238

Test plan

  • yaml.safe_load on ci.yml and .pre-commit-config.yaml parses cleanly
  • pr-title CI job runs against this PR

@bdraco bdraco marked this pull request as ready for review May 19, 2026 20:55
@bdraco bdraco merged commit 93c3112 into master May 19, 2026
30 checks passed
@bdraco bdraco deleted the ci/replace-commitlint-with-pr-title-check branch May 19, 2026 20:55
@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.76%. Comparing base (228af17) to head (0aceb63).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1740   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          33       33           
  Lines        3440     3440           
  Branches      473      473           
=======================================
  Hits         3432     3432           
  Misses          5        5           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented May 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 11 untouched benchmarks


Comparing ci/replace-commitlint-with-pr-title-check (0aceb63) with master (228af17)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant