test: speed up test_async_wait_unblocks_on_update#1702
Merged
bdraco merged 1 commit intoMay 17, 2026
Conversation
…xture Drops runtime from ~2.0s to ~0.4s by shortening probe/announce intervals on loopback. The test only asserts wait-unblock latency bounds (<3000ms, <1000ms), so faster register cycles do not weaken what it pins.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1702 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 33 33
Lines 3410 3410
Branches 464 464
=======================================
Hits 3402 3402
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdraco
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add the
quick_timingfixture totest_async_wait_unblocks_on_update.Why
The test took ~2.0s on loopback because
async_register_servicepaid the full RFC 6762 probe/announce intervals (_CHECK_TIME=500ms,_REGISTER_TIME=225ms × 3). On 127.0.0.1 those values are dead air.How
The fixture (already in
conftest.py) patches the intervals down to 10ms — same pattern the project's learnings already recommend for loopback-only tests. The test's assertions (<3000ms,<1000ms) are wait-unblock latency bounds and stay meaningful with shorter register cycles.Testing
1 passed in 2.02s1 passed in 0.43s--count=5):5 passed in 1.68sQuality Report
Changes: 1 file changed, 1 insertion(+), 1 deletion(-)
Code scan: clean
Tests: passed (4 PASSED)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline