Skip to content

test: drop pending multicast responses before TOCTOU assertion #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
May 17, 2026
Merged

test: drop pending multicast responses before TOCTOU assertion #1701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/test_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,16 @@ async def test_service_info_async_request(quick_timing: None) -> None:
assert aiosinfos[1] is not None
assert aiosinfos[1].addresses == [socket.inet_aton("10.0.1.5")]

# Drop pending multicast responses queued under the original
# `info` / `info2` registrations. Their snapshots predate the
# `async_update_service` swap, so if they flushed after
# `_clear_cache` below they would poison `aiosinfo.server`
# with `ash-1.local.` and the `_is_complete=False` loop would
# then keep asking for an A record nobody answers. The pending
# `loop.call_at` for each queue fires harmlessly on the empty
# deque.
aiozc.zeroconf.out_queue.queue.clear()
aiozc.zeroconf.out_delay_queue.queue.clear()
aiosinfo = AsyncServiceInfo(type_, registration_name)
_clear_cache(aiozc.zeroconf)
# Generating the race condition is almost impossible
Expand Down
Loading