Skip to content

fix: hold a strong reference to the AsyncEngine setup task #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 2 commits into from
Feb 18, 2025
Merged

fix: hold a strong reference to the AsyncEngine setup task #1533

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee1847d
fix: hold a strong reference to the AsyncEngine setup task
bdraco Feb 18, 2025
a0d26af
fix: hold a strong reference to the AsyncEngine setup task
bdraco Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/zeroconf/_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ class AsyncEngine:
"_cleanup_timer",
"_listen_socket",
"_respond_sockets",
"_setup_task",
"loop",
"protocols",
"readers",
Expand All @@ -73,6 +74,7 @@ def __init__(
self._listen_socket = listen_socket
self._respond_sockets = respond_sockets
self._cleanup_timer: asyncio.TimerHandle | None = None
self._setup_task: asyncio.Task[None] | None = None

def setup(
self,
Expand All @@ -82,14 +84,15 @@ def setup(
"""Set up the instance."""
self.loop = loop
self.running_future = loop.create_future()
self.loop.create_task(self._async_setup(loop_thread_ready))
self._setup_task = self.loop.create_task(self._async_setup(loop_thread_ready))

async def _async_setup(self, loop_thread_ready: threading.Event | None) -> None:
"""Set up the instance."""
self._async_schedule_next_cache_cleanup()
await self._async_create_endpoints()
assert self.running_future is not None
self.running_future.set_result(True)
if not self.running_future.done():
self.running_future.set_result(True)
if loop_thread_ready:
loop_thread_ready.set()

Expand Down Expand Up @@ -135,6 +138,8 @@ def _async_schedule_next_cache_cleanup(self) -> None:

async def _async_close(self) -> None:
"""Cancel and wait for the cleanup task to finish."""
assert self._setup_task is not None
await self._setup_task
self._async_shutdown()
await asyncio.sleep(0) # flush out any call soons
assert self._cleanup_timer is not None
Expand Down