Skip to content

chore: cleanup typing in net utils#1521

Merged
bdraco merged 2 commits into
masterfrom
net_typing
Feb 13, 2025
Merged

chore: cleanup typing in net utils#1521
bdraco merged 2 commits into
masterfrom
net_typing

Conversation

@bdraco

@bdraco bdraco commented Feb 13, 2025

Copy link
Copy Markdown
Member

ifaddr didn't use to be typed until ifaddr/ifaddr#53 so we can clean this up a bit now

@codecov

codecov Bot commented Feb 13, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (e7adac9) to head (1a0587e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1521      +/-   ##
==========================================
- Coverage   99.79%   99.79%   -0.01%     
==========================================
  Files          33       33              
  Lines        3387     3386       -1     
  Branches      461      461              
==========================================
- Hits         3380     3379       -1     
  Misses          5        5              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Feb 13, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #1521 will not alter performance

Comparing net_typing (1a0587e) with master (e7adac9)

Summary

✅ 6 untouched benchmarks

@bdraco bdraco merged commit cf44289 into master Feb 13, 2025
@bdraco bdraco deleted the net_typing branch February 13, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant