Skip to content

fix: improve helpfulness of ServiceInfo.request assertions #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 2 commits into from
Sep 8, 2024
Merged

fix: improve helpfulness of ServiceInfo.request assertions #1408

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
719ac9e
fix: improve helpfulness of sync ServiceInfo.request assertions
bdraco Sep 8, 2024
41619d9
fix: improve helpfulness of sync ServiceInfo.request assertions
bdraco Sep 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/zeroconf/_services/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,8 @@ def request(
:param addr: address to send the request to
:param port: port to send the request to
"""
assert zc.loop is not None and zc.loop.is_running()
assert zc.loop is not None, "Zeroconf instance must have a loop, was it not started?"
assert zc.loop.is_running(), "Zeroconf instance loop must be running, was it already stopped?"
if zc.loop == get_running_loop():
raise RuntimeError("Use AsyncServiceInfo.async_request from the event loop")
return bool(
Expand Down