Skip to content

chore: fix race in dns tests #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
Nov 5, 2023
Merged

chore: fix race in dns tests #1300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_dns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,13 @@ def test_dns_record_is_stale(self):
now = current_time_millis()
assert record.is_stale(now) is False
assert record.is_stale(now + (8 / 4.1 * 1000)) is False
assert record.is_stale(now + (8 / 2 * 1000)) is True
assert record.is_stale(now + (8 / 1.9 * 1000)) is True
assert record.is_stale(now + (8 * 1000)) is True

def test_dns_record_is_recent(self):
now = current_time_millis()
record = r.DNSRecord('irrelevant', const._TYPE_SRV, const._CLASS_IN, 8)
assert record.is_recent(now + (8 / 4.1 * 1000)) is True
assert record.is_recent(now + (8 / 4.2 * 1000)) is True
assert record.is_recent(now + (8 / 3 * 1000)) is False
assert record.is_recent(now + (8 / 2 * 1000)) is False
assert record.is_recent(now + (8 * 1000)) is False
Expand Down