feat: optimize unpacking properties in ServiceInfo - #1225
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1225 +/- ##
==========================================
+ Coverage 99.49% 99.82% +0.32%
==========================================
Files 25 25
Lines 2794 2790 -4
Branches 480 479 -1
==========================================
+ Hits 2780 2785 +5
+ Misses 8 3 -5
+ Partials 6 2 -4
☔ View full report in Codecov by Sentry. |
bdraco
marked this pull request as ready for review
August 15, 2023 20:07
bboe
added a commit
to bboe/python-zeroconf
that referenced
this pull request
Aug 12, 2026
RFC 6763 6.4: a key with no '=' is a boolean attribute; `key=` is present with an empty value. Collapsing both to None makes them indistinguishable, so a received `key=` re-encodes as a bare `key`. Regression in python-zeroconf#1225 (first released in 0.80.0), which replaced explicit branching on the separator with `value or None`. Restores the behaviour python-zeroconf#226 introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.