Skip to content

Use unique name in test_service_browser_expire_callbacks test#1069

Merged
bdraco merged 2 commits into
python-zeroconf:masterfrom
bdraco:use_unique_name_tests
May 5, 2022
Merged

Use unique name in test_service_browser_expire_callbacks test#1069
bdraco merged 2 commits into
python-zeroconf:masterfrom
bdraco:use_unique_name_tests

Conversation

@bdraco

@bdraco bdraco commented May 5, 2022

Copy link
Copy Markdown
Member

The QuestionHistory guards were causing random test failures

@bdraco bdraco force-pushed the use_unique_name_tests branch from bb0b1f1 to 9377d11 Compare May 5, 2022 16:18
@codecov-commenter

codecov-commenter commented May 5, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1069 (c388826) into master (f9b2816) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1069   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          23       23           
  Lines        2544     2544           
  Branches      473      473           
=======================================
  Hits         2542     2542           
  Misses          1        1           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b2816...c388826. Read the comment docs.

@bdraco bdraco merged commit 89c9022 into python-zeroconf:master May 5, 2022
@bdraco bdraco deleted the use_unique_name_tests branch May 5, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants