Skip to content

Throw NotRunningException when Zeroconf is not running#1033

Merged
bdraco merged 5 commits into
python-zeroconf:masterfrom
bdraco:zeroconf_not_running_exception
Nov 18, 2021
Merged

Throw NotRunningException when Zeroconf is not running#1033
bdraco merged 5 commits into
python-zeroconf:masterfrom
bdraco:zeroconf_not_running_exception

Conversation

@bdraco

@bdraco bdraco commented Nov 18, 2021

Copy link
Copy Markdown
Member
  • Before this change the consumer would get a timeout or an EventLoopBlocked
    exception when calling ServiceInfo.*request when the instance had already been shutdown.
    This was quite a confusing result.

…ning Zeroconf instance

- Before this change the consumer would get a timeout or an EventLoopBlocked
  exception which was confusing.
@codecov-commenter

codecov-commenter commented Nov 18, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1033 (c245aae) into master (21bd107) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1033   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files          23       23           
  Lines        2545     2550    +5     
  Branches      420      423    +3     
=======================================
+ Hits         2536     2541    +5     
  Misses          6        6           
  Partials        3        3           
Impacted Files Coverage Δ
zeroconf/__init__.py 100.00% <ø> (ø)
zeroconf/_core.py 100.00% <100.00%> (ø)
zeroconf/_exceptions.py 100.00% <100.00%> (ø)
zeroconf/asyncio.py 100.00% <100.00%> (ø)
zeroconf/const.py 97.36% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21bd107...c245aae. Read the comment docs.

@bdraco bdraco merged commit 28938d2 into python-zeroconf:master Nov 18, 2021
@bdraco bdraco deleted the zeroconf_not_running_exception branch November 18, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants