Skip to content

Skip unavailable interfaces during socket bind#1028

Merged
bdraco merged 4 commits into
python-zeroconf:masterfrom
bdraco:skip_unavailable_addresses
Nov 13, 2021
Merged

Skip unavailable interfaces during socket bind#1028
bdraco merged 4 commits into
python-zeroconf:masterfrom
bdraco:skip_unavailable_addresses

Conversation

@bdraco

@bdraco bdraco commented Nov 13, 2021

Copy link
Copy Markdown
Member
  • We already skip these when adding multicast members.
    Apply the same logic to the socket bind call

Reference home-assistant/core#57678

- We already skip these when adding multicast members.
  Apply the same logic to the socket bind call
@codecov-commenter

codecov-commenter commented Nov 13, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1028 (cad1621) into master (8b0dc48) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1028   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          23       23           
  Lines        2526     2535    +9     
  Branches      413      419    +6     
=======================================
+ Hits         2518     2527    +9     
  Misses          5        5           
  Partials        3        3           
Impacted Files Coverage Δ
zeroconf/_utils/net.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b0dc48...cad1621. Read the comment docs.

@bdraco bdraco merged commit aa59998 into python-zeroconf:master Nov 13, 2021
@bdraco bdraco deleted the skip_unavailable_addresses branch November 13, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants