Skip to content

Ignore stale records when considering to ask questions #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bdraco wants to merge 1 commit into from
+4 −3
Closed

Ignore stale records when considering to ask questions #1014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions zeroconf/_protocol/outgoing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def add_question_or_one_cache(
) -> None:
"""Add a question if it is not already cached."""
cached_entry = cache.get_by_details(name, type_, class_)
if not cached_entry:
if not cached_entry or cached_entry.is_stale(now):
self.add_question(DNSQuestion(name, type_, class_))
else:
self.add_answer_at_time(cached_entry, now)
Expand All @@ -174,11 +174,12 @@ def add_question_or_all_cache(
This is currently only used for IPv6 addresses.
"""
cached_entries = cache.get_all_by_details(name, type_, class_)
if not cached_entries:
if not cached_entries or any(entry.is_stale(now) for entry in cached_entries):
self.add_question(DNSQuestion(name, type_, class_))
return
for cached_entry in cached_entries:
self.add_answer_at_time(cached_entry, now)
if not cached_entry.is_stale(now):
self.add_answer_at_time(cached_entry, now)

def _pack(self, format_: Union[bytes, str], size: int, value: Any) -> None:
self.data.append(struct.pack(format_, value))
Expand Down