Ignore stale records when considering to ask questions#1014
Closed
bdraco wants to merge 1 commit into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1014 +/- ##
==========================================
- Coverage 99.84% 99.80% -0.04%
==========================================
Files 23 23
Lines 2543 2544 +1
Branches 471 472 +1
==========================================
Hits 2539 2539
Misses 3 3
- Partials 1 2 +1
Continue to review full report at Codecov.
|
Member
Author
|
This needs more coverage, but manually testing looks good |
Member
Author
|
We can do this part. But part 2 probably isn't going to happen unless I can figure out how to avoid a breaking change |
1 similar comment
Member
Author
|
We can do this part. But part 2 probably isn't going to happen unless I can figure out how to avoid a breaking change |
bdraco
force-pushed
the
ignore_stale_records_asking
branch
from
9b96f9c to
7f2de64
Compare
Member
Author
|
fixed via #1348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part 1 of #1013 (comment)