feat: speed up ServiceBrowsers with a pxd for the signal interface

bdraco · bdraco · commit eddd5dcc808f · 2023-11-04T16:06:33.000-05:00
diff --git a/build_ext.py b/build_ext.py
@@ -33,6 +33,7 @@ def build(setup_kwargs: Any) -> None:
                         "src/zeroconf/_handlers/record_manager.py",
                         "src/zeroconf/_handlers/multicast_outgoing_queue.py",
                         "src/zeroconf/_handlers/query_handler.py",
+                        "src/zeroconf/_services/__init__.py",
                         "src/zeroconf/_services/browser.py",
                         "src/zeroconf/_services/info.py",
                         "src/zeroconf/_services/registry.py",
diff --git a/src/zeroconf/_services/__init__.pxd b/src/zeroconf/_services/__init__.pxd
@@ -0,0 +1,11 @@
+
+import cython
+
+
+cdef class Signal:
+
+    cdef list _handlers
+
+cdef class SignalRegistrationInterface:
+
+    cdef list _handlers
diff --git a/src/zeroconf/_services/browser.pxd b/src/zeroconf/_services/browser.pxd
@@ -5,6 +5,7 @@ from .._cache cimport DNSCache
 from .._protocol.outgoing cimport DNSOutgoing, DNSPointer, DNSQuestion, DNSRecord
 from .._updates cimport RecordUpdateListener
 from .._utils.time cimport current_time_millis, millis_to_seconds
+from . cimport Signal, SignalRegistrationInterface
 
 
 cdef bint TYPE_CHECKING
diff --git a/src/zeroconf/_services/browser.py b/src/zeroconf/_services/browser.py
@@ -388,7 +388,7 @@ def _enqueue_callback(
             state_change is SERVICE_STATE_CHANGE_ADDED
             or (
                 state_change is SERVICE_STATE_CHANGE_REMOVED
-                and self._pending_handlers.get(key) != SERVICE_STATE_CHANGE_ADDED
+                and self._pending_handlers.get(key) is not SERVICE_STATE_CHANGE_ADDED
             )
             or (state_change is SERVICE_STATE_CHANGE_UPDATED and key not in self._pending_handlers)
         ):

Original file line number	Diff line number	Diff line change
`@@ -388,7 +388,7 @@ def _enqueue_callback(`
`388`	`388`	`state_change is SERVICE_STATE_CHANGE_ADDED`
`389`	`389`	`or (`
`390`	`390`	`state_change is SERVICE_STATE_CHANGE_REMOVED`
`391`		`- and self._pending_handlers.get(key) != SERVICE_STATE_CHANGE_ADDED`
	`391`	`+ and self._pending_handlers.get(key) is not SERVICE_STATE_CHANGE_ADDED`
`392`	`392`	`)`
`393`	`393`	`or (state_change is SERVICE_STATE_CHANGE_UPDATED and key not in self._pending_handlers)`
`394`	`394`	`):`