Narrow exception catch in DNSAddress.__repr__ to only expected exceptions (#473)

bdraco · web-flow · commit b8534130ec31 · 2021-06-05T23:18:34.000-10:00
diff --git a/zeroconf/__init__.py b/zeroconf/__init__.py
@@ -597,7 +597,7 @@ def __repr__(self) -> str:
                     socket.AF_INET6 if _is_v6_address(self.address) else socket.AF_INET, self.address
                 )
             )
-        except Exception:  # pylint: disable=broad-except  # TODO stop catching all Exceptions
+        except (ValueError, OSError):
             return self.to_string(str(self.address))
 
 

Original file line number	Diff line number	Diff line change
`@@ -597,7 +597,7 @@ def __repr__(self) -> str:`
`597`	`597`	`socket.AF_INET6 if _is_v6_address(self.address) else socket.AF_INET, self.address`
`598`	`598`	`)`
`599`	`599`	`)`
`600`		`- except Exception: # pylint: disable=broad-except # TODO stop catching all Exceptions`
	`600`	`+ except (ValueError, OSError):`
`601`	`601`	`return self.to_string(str(self.address))`
`602`	`602`
`603`	`603`