Skip to content

Commit b60f307

Browse files
authored
Remove AA flags from handlers test (#693)
- The flag was added by mistake when copying from other tests
1 parent 8a25a44 commit b60f307

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

tests/test_handlers.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ def test_ptr_optimization():
230230
zc.register_service(info)
231231

232232
# Verify we won't respond for 1s with the same multicast
233-
query = r.DNSOutgoing(const._FLAGS_QR_QUERY | const._FLAGS_AA)
233+
query = r.DNSOutgoing(const._FLAGS_QR_QUERY)
234234
query.add_question(r.DNSQuestion(info.type, const._TYPE_PTR, const._CLASS_IN))
235235
unicast_out, multicast_out = zc.query_handler.response(
236236
[r.DNSIncoming(packet) for packet in query.packets()], None, const._MDNS_PORT
@@ -242,7 +242,7 @@ def test_ptr_optimization():
242242
_clear_cache(zc)
243243

244244
# Verify we will now respond
245-
query = r.DNSOutgoing(const._FLAGS_QR_QUERY | const._FLAGS_AA)
245+
query = r.DNSOutgoing(const._FLAGS_QR_QUERY)
246246
query.add_question(r.DNSQuestion(info.type, const._TYPE_PTR, const._CLASS_IN))
247247
unicast_out, multicast_out = zc.query_handler.response(
248248
[r.DNSIncoming(packet) for packet in query.packets()], None, const._MDNS_PORT
@@ -340,7 +340,7 @@ def test_unicast_response():
340340
_clear_cache(zc)
341341

342342
# query
343-
query = r.DNSOutgoing(const._FLAGS_QR_QUERY | const._FLAGS_AA)
343+
query = r.DNSOutgoing(const._FLAGS_QR_QUERY)
344344
query.add_question(r.DNSQuestion(info.type, const._TYPE_PTR, const._CLASS_IN))
345345
unicast_out, multicast_out = zc.query_handler.response(
346346
[r.DNSIncoming(packet) for packet in query.packets()], "1.2.3.4", 1234
@@ -413,7 +413,7 @@ def _validate_complete_response(query, out):
413413
assert has_srv and has_txt and has_a
414414

415415
# With QU should respond to only unicast when the answer has been recently multicast
416-
query = r.DNSOutgoing(const._FLAGS_QR_QUERY | const._FLAGS_AA)
416+
query = r.DNSOutgoing(const._FLAGS_QR_QUERY)
417417
question = r.DNSQuestion(info.type, const._TYPE_PTR, const._CLASS_IN)
418418
question.unique = True # Set the QU bit
419419
assert question.unicast is True
@@ -427,7 +427,7 @@ def _validate_complete_response(query, out):
427427

428428
_clear_cache(zc)
429429
# With QU should respond to only multicast since the response hasn't been seen since 75% of the ttl
430-
query = r.DNSOutgoing(const._FLAGS_QR_QUERY | const._FLAGS_AA)
430+
query = r.DNSOutgoing(const._FLAGS_QR_QUERY)
431431
question = r.DNSQuestion(info.type, const._TYPE_PTR, const._CLASS_IN)
432432
question.unique = True # Set the QU bit
433433
assert question.unicast is True
@@ -439,7 +439,7 @@ def _validate_complete_response(query, out):
439439
_validate_complete_response(query, multicast_out)
440440

441441
# With QU set and an authorative answer (probe) should respond to both unitcast and multicast since the response hasn't been seen since 75% of the ttl
442-
query = r.DNSOutgoing(const._FLAGS_QR_QUERY | const._FLAGS_AA)
442+
query = r.DNSOutgoing(const._FLAGS_QR_QUERY)
443443
question = r.DNSQuestion(info.type, const._TYPE_PTR, const._CLASS_IN)
444444
question.unique = True # Set the QU bit
445445
assert question.unicast is True
@@ -453,7 +453,7 @@ def _validate_complete_response(query, out):
453453

454454
_inject_response(zc, r.DNSIncoming(multicast_out.packets()[0]))
455455
# With the cache repopulated; should respond to only unicast when the answer has been recently multicast
456-
query = r.DNSOutgoing(const._FLAGS_QR_QUERY | const._FLAGS_AA)
456+
query = r.DNSOutgoing(const._FLAGS_QR_QUERY)
457457
question = r.DNSQuestion(info.type, const._TYPE_PTR, const._CLASS_IN)
458458
question.unique = True # Set the QU bit
459459
assert question.unicast is True

0 commit comments

Comments
 (0)