feat: improve response handler performance

bdraco · bdraco · commit 7f2b7e45911c · 2024-09-25T08:50:20.000-05:00
diff --git a/build_ext.py b/build_ext.py
@@ -41,6 +41,7 @@ def build(setup_kwargs: Any) -> None:
                         "src/zeroconf/_services/browser.py",
                         "src/zeroconf/_services/info.py",
                         "src/zeroconf/_services/registry.py",
+                        "src/zeroconf/_transport.py",
                         "src/zeroconf/_updates.py",
                         "src/zeroconf/_utils/ipaddress.py",
                         "src/zeroconf/_utils/time.py",
diff --git a/src/zeroconf/_handlers/query_handler.pxd b/src/zeroconf/_handlers/query_handler.pxd
@@ -7,6 +7,7 @@ from .._history cimport QuestionHistory
 from .._protocol.incoming cimport DNSIncoming
 from .._services.info cimport ServiceInfo
 from .._services.registry cimport ServiceRegistry
+from .._transport cimport _WrappedTransport
 from .answers cimport (
     QuestionAnswers,
     construct_outgoing_multicast_answers,
@@ -115,6 +116,6 @@ cdef class QueryHandler:
         list packets,
         object addr,
         object port,
-        object transport,
+        _WrappedTransport transport,
         tuple v6_flow_scope
     )
diff --git a/src/zeroconf/_listener.pxd b/src/zeroconf/_listener.pxd
@@ -5,11 +5,13 @@ from ._handlers.query_handler cimport QueryHandler
 from ._handlers.record_manager cimport RecordManager
 from ._protocol.incoming cimport DNSIncoming
 from ._services.registry cimport ServiceRegistry
+from ._transport cimport _WrappedTransport
 from ._utils.time cimport current_time_millis, millis_to_seconds
 
 
 cdef object log
 cdef object DEBUG_ENABLED
+cdef object randint
 cdef bint TYPE_CHECKING
 
 cdef cython.uint _MAX_MSG_ABSOLUTE
@@ -26,7 +28,7 @@ cdef class AsyncListener:
     cdef public cython.bytes data
     cdef public double last_time
     cdef public DNSIncoming last_message
-    cdef public object transport
+    cdef public _WrappedTransport transport
     cdef public object sock_description
     cdef public cython.dict _deferred
     cdef public cython.dict _timers
@@ -45,15 +47,15 @@ cdef class AsyncListener:
         DNSIncoming msg,
         object addr,
         object port,
-        object transport,
+        _WrappedTransport transport,
         tuple v6_flow_scope
     )
 
-    cpdef _respond_query(
+    cpdef void _respond_query(
         self,
         object msg,
         object addr,
         object port,
-        object transport,
+        _WrappedTransport transport,
         tuple v6_flow_scope
     )
diff --git a/src/zeroconf/_listener.py b/src/zeroconf/_listener.py
@@ -46,6 +46,9 @@
 DEBUG_ENABLED = partial(log.isEnabledFor, logging.DEBUG)
 
 
+randint = random.randint
+
+
 class AsyncListener:
     """A Listener is used by this module to listen on the multicast
     group to which DNS messages are sent, allowing the implementation
@@ -193,7 +196,7 @@ def handle_query_or_defer(
     ) -> None:
         """Deal with incoming query packets.  Provides a response if
         possible."""
-        if not msg.truncated:
+        if not msg.is_truncated():
             self._respond_query(msg, addr, port, transport, v6_flow_scope)
             return
 
@@ -203,7 +206,7 @@ def handle_query_or_defer(
             if incoming.data == msg.data:
                 return
         deferred.append(msg)
-        delay = millis_to_seconds(random.randint(*_TC_DELAY_RANDOM_INTERVAL))  # noqa: S311
+        delay = millis_to_seconds(randint(*_TC_DELAY_RANDOM_INTERVAL))
         loop = self.zc.loop
         assert loop is not None
         self._cancel_any_timers_for_addr(addr)
diff --git a/src/zeroconf/_protocol/incoming.pxd b/src/zeroconf/_protocol/incoming.pxd
@@ -74,6 +74,8 @@ cdef class DNSIncoming:
 
     cpdef bint is_response(self)
 
+    cpdef bint is_truncated(self)
+
     @cython.locals(
         off="unsigned int",
         label_idx="unsigned int",
diff --git a/src/zeroconf/_protocol/incoming.py b/src/zeroconf/_protocol/incoming.py
@@ -136,14 +136,18 @@ def is_response(self) -> bool:
         """Returns true if this is a response."""
         return (self.flags & _FLAGS_QR_MASK) == _FLAGS_QR_RESPONSE
 
+    def is_truncated(self) -> bool:
+        """Returns true if this is truncated."""
+        return (self.flags & _FLAGS_TC) == _FLAGS_TC
+
     def has_qu_question(self) -> bool:
         """Returns true if any question is a QU question."""
         return self._has_qu_question
 
     @property
     def truncated(self) -> bool:
         """Returns true if this is a truncated."""
-        return (self.flags & _FLAGS_TC) == _FLAGS_TC
+        return self.is_truncated()
 
     @property
     def questions(self) -> List[DNSQuestion]:
diff --git a/src/zeroconf/_transport.pxd b/src/zeroconf/_transport.pxd
@@ -0,0 +1,10 @@
+
+import cython
+
+cdef class _WrappedTransport:
+
+    cdef public object transport
+    cdef public bint is_ipv6
+    cdef public object sock
+    cdef public int fileno
+    cdef public tuple sock_name
