Skip to content

__all__ missing actual imports#238

Open
Avasam wants to merge 7 commits into
python-xlib:masterfrom
Avasam:__all__+imports
Open

__all__ missing actual imports#238
Avasam wants to merge 7 commits into
python-xlib:masterfrom
Avasam:__all__+imports

Conversation

@Avasam

@Avasam Avasam commented Nov 4, 2022

Copy link
Copy Markdown
Contributor

Two changes

  1. Added missing imports for modules re-exported in __all__.
  2. Exported symbol list may be incorrect if an operation is done on __all__.

Closes #240

Comment thread Xlib/ext/randr.py Outdated
@vasily-v-ryabov

Copy link
Copy Markdown
Collaborator

If it's still actual, please resolve conflicts.

@codecov-commenter

codecov-commenter commented Dec 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #238 (92fd325) into master (4e8bbf8) will increase coverage by 4.58%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   78.21%   82.80%   +4.58%     
==========================================
  Files          42       63      +21     
  Lines        4705     7484    +2779     
==========================================
+ Hits         3680     6197    +2517     
- Misses       1025     1287     +262     

@Avasam

Avasam commented Jul 8, 2023

Copy link
Copy Markdown
Contributor Author

@vasily-v-ryabov Conflicts have been resolved. Could I get a review on this?

@Avasam

Avasam commented Aug 18, 2024

Copy link
Copy Markdown
Contributor Author

@python-xlib @vasily-v-ryabov bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary import

3 participants