Use encode_array() in Drawable._get_struct_prop()#181
Merged
vasily-v-ryabov merged 1 commit intopython-xlib:masterfrom Nov 22, 2020
Merged
Use encode_array() in Drawable._get_struct_prop()#181vasily-v-ryabov merged 1 commit intopython-xlib:masterfrom
vasily-v-ryabov merged 1 commit intopython-xlib:masterfrom
Conversation
The Xlib/protocol/rq.py file defines an helper function encode_array()
that calls tostring() or tobytes() depending on which python version is
used.
The package maintainer Christoph Egger reported that the testsuite of
the herbstluftwm project fails[1] with the error:
def _get_struct_prop(self, pname, ptype, pstruct):
r = self.get_property(pname, ptype, 0, pstruct.static_size // 4)
if r and r.format == 32:
> value = r.value.tostring()
E AttributeError: 'array.array' object has no attribute 'tostring'
/usr/lib/python3/dist-packages/Xlib/xobject/drawable.py:782: AttributeError
Backtrace:
../tests/conftest.py:624: in is_window_urgent
hints = window.get_wm_hints()
/usr/lib/python3/dist-packages/Xlib/xobject/drawable.py:756: in get_wm_hints
return self._get_struct_prop(Xatom.WM_HINTS, Xatom.WM_HINTS,
I assume it should be rq.encode_array() instead of .tostring() but I'm
not terribly sure.
[1] https://pbot.rmdir.de/u/4lU98VkXkdjSypXmdekh5g
Contributor
Author
|
|
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
=======================================
Coverage 81.99% 81.99%
=======================================
Files 42 42
Lines 4855 4855
=======================================
Hits 3981 3981
Misses 874 874 |
Collaborator
|
Looks reasonable. Thanks! Will do the same fix for XInput. |
Collaborator
|
Released as 0.29. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Xlib/protocol/rq.py file defines an helper function encode_array()
that calls tostring() or tobytes() depending on which python version is
used.
The package maintainer Christoph Egger reported that the testsuite of
the herbstluftwm project fails[1] with the error:
Backtrace:
I assume it should be rq.encode_array() instead of .tostring() but I'm
not terribly sure.
[1] https://pbot.rmdir.de/u/4lU98VkXkdjSypXmdekh5g