Skip to content

Conversation

@benoit-pierre
Copy link
Member

Move finalized classes for resource types at the instance level, to avoid creating recursive class hierarchies.

Fix #136.

Move finalized classes for resource types at the instance level,
to avoid creating recursive class hierarchies.
@codecov-io
Copy link

codecov-io commented Feb 3, 2019

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   81.29%   81.29%           
=======================================
  Files          38       38           
  Lines        4427     4427           
=======================================
  Hits         3599     3599           
  Misses        828      828

Copy link
Collaborator

@vasily-v-ryabov vasily-v-ryabov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How about bumping version to 0.25?

@vasily-v-ryabov vasily-v-ryabov merged commit 936af08 into python-xlib:master Feb 3, 2019
@vasily-v-ryabov
Copy link
Collaborator

@benoit-pierre I've just found TestPyPI project has only one maintainer. Maybe it makes sense to add my account as well: vasily-v-ryabov (the same as on main PyPI). I'm going to publish 0.25 on main PyPI skipping TestPyPI now. I post releases on PyPI not so often (2-4 times a year), changes in twine and PyPI can be accumulated faster. So testing upload first would be better for me.

@benoit-pierre benoit-pierre deleted the fix_memory_leak branch February 3, 2019 21:25
@benoit-pierre
Copy link
Member Author

There's no much point in pushing to the test instance of PyPI, unless testing things like a new format for the description (markdown support thanks to the new description type). For checking release artifacts, a combination of check-manifest, setup.py check and twine check is what I use.

@vasily-v-ryabov
Copy link
Collaborator

OK, thanks. Python tells that setup.py check is deprecated so it looks like twine check is enough for the most cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants