protocol/rq: fix string decoding#111
Merged
vasily-v-ryabov merged 1 commit intopython-xlib:masterfrom Mar 19, 2018
Merged
Conversation
As it turns out, character strings should be decoded using Latin-1, see for example: https://www.x.org/releases/X11R7.7/doc/xproto/x11protocol.html#requests:InternAtom
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=======================================
Coverage 81.36% 81.36%
=======================================
Files 38 38
Lines 4417 4417
=======================================
Hits 3594 3594
Misses 823 823 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like I was wrong in #92: using ASCII can cause issues (see opensteno/plover#919). As it turns out character strings should be decoded using Latin-1, see for example: https://www.x.org/releases/X11R7.7/doc/xproto/x11protocol.html#requests:InternAtom.