Fix a bunch of errors in color_brewer and add unit tests
#115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The non-qualitative schemes should be extendable. This commit adds this feature. Fixes python-visualization#104 Fixes python-visualization#114 Moreover, the following error was not reported via issues and are fixed: * TypeError in the linear_gradient function when trying to extend any scheme. Indeed, in color_brewer, the key searched in the scheme database was not found, thus, it was passing `None` instead of a real scheme vector to linear_gradient; * The scheme 'viridis' was not in the base_codes JSON; * Multiple scheme hadn't any metadata in scheme_info JSON; * When a `n` value provided to `color_scheme` was a float, it tried to select an unknown scheme without raising the right Exception type.
Selenium just removed that method in version 4.3.0. See the CHANGES: https://github.com/SeleniumHQ/selenium/blob/a4995e2c096239b42c373f26498a6c9bb4f2b3e7/py/CHANGES
Conengmo
requested changes
Nov 4, 2022
Member
Conengmo
left a comment
Conengmo
left a comment
There was a problem hiding this comment.
Thanks so much for your PR. I'm happy you fixed these glaring issues with the color brewer and also the added tests!
I have one comment regarding the longest scheme name, could you take a look please?
Member
|
Thanks again @ajabep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The non-qualitative schemes should be extendable. This commit adds this feature.
Fixes #104 and #114. Also probably fix python-visualization/folium#1270.
Moreover, the following error was not reported via issues and are fixed:
Noneinstead of a real scheme vector to linear_gradient;nvalue provided tocolor_schemewas a float, it tried to select an unknown scheme without raising the right Exception type.WebDriver.find_element_by_css_selector.