Commit some pins to fix tests as they are#420
Merged
Conversation
Callek
force-pushed
the
callek/fix-tests-2026-05
branch
from
af0ba24 to
077f7e3
Compare
Callek
force-pushed
the
callek/fix-tests-2026-05
branch
from
077f7e3 to
7c26ee2
Compare
effigies
approved these changes
May 26, 2026
effigies
left a comment
effigies
left a comment
Contributor
There was a problem hiding this comment.
Looks good. One long term approach could be to create a legacy selector for tox that pins old setuptools, and then mark tests as legacy, which only run if a compatible setuptools is installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just unbreaks tests for now. I'm working on an additional PR that doesn't require the pin