Replace pkg_resources parse_version in Git test#418
Draft
Mirochill wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packaging.version.parsein the Git test instead of the removedpkg_resources.parse_versionpackaging>=20tox dependencyFixes #414
Validation
git diff --checkgit diff --cached --checkgit diff --check HEAD~1..HEADRemote CI
Toxrun 26342344094 completed withbootstrapandbuildpassing.test*jobs failed intest/git/test_invocations.pyaroundsetup.py develop/ isolated pip installs (--find-linkshandling and missingsetuptools>=40.8.0in local links).masterToxruns 26009541783 and 26010403410 are also failing on the same workflow, so this does not appear to be caused by the one-line import replacement in this PR.