FIX: Always bootstrap in setup.py to avoid incompatibility with old versioneer#344
Merged
Merged
Conversation
Always bootstrap versioneer and use the newly bootstrapped version in `setup.py`. This avoids compatibility problems when there is an old version of versioneer installed (<= 0.23) that does not define `get_version()` and therefore causes `setup.py` to fail. Thanks to Chris Markiewicz for the suggested solution. Fixes python-versioneer#343
effigies
changed the title
Contributor
|
Looks great, and tests are passing. Thanks very much for your help! |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always bootstrap versioneer and use the newly bootstrapped version in
setup.py. This avoids compatibility problems when there is an old version of versioneer installed (<= 0.23) that does not defineget_version()and therefore causessetup.pyto fail.Thanks to Chris Markiewicz for the suggested solution.
Fixes #343