Skip to content

CI: python-version should be a string, not a float#340

Merged
effigies merged 1 commit into
python-versioneer:masterfrom
DimitriPapadopoulos:python-version
Sep 26, 2022
Merged

CI: python-version should be a string, not a float#340
effigies merged 1 commit into
python-versioneer:masterfrom
DimitriPapadopoulos:python-version

Conversation

@DimitriPapadopoulos

Copy link
Copy Markdown
Contributor

This shows clearly with '3.10' which is different from '3.1'.

This shows clearly with '3.10' which is different from '3.1'.
@effigies

Copy link
Copy Markdown
Contributor

Have you found this causes problems in some situations?

@DimitriPapadopoulos

Copy link
Copy Markdown
Contributor Author

Yes, when a version ends with 0.

For documentation purposes, I feel it is better to use explicit strings. Otherwise, other maintainers may for example trigger this error when updating a version from 3.9 to 3.10.

@effigies

Copy link
Copy Markdown
Contributor

Fair enough.

@effigies effigies merged commit 44d07c5 into python-versioneer:master Sep 26, 2022
@DimitriPapadopoulos DimitriPapadopoulos deleted the python-version branch September 27, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants