Skip to content

ENH: in verbose mode do not hide stderr of git rev-parse#318

Merged
effigies merged 1 commit into
python-versioneer:masterfrom
yarikoptic:enh-not-verbose
Aug 24, 2022
Merged

ENH: in verbose mode do not hide stderr of git rev-parse#318
effigies merged 1 commit into
python-versioneer:masterfrom
yarikoptic:enh-not-verbose

Conversation

@yarikoptic

@yarikoptic yarikoptic commented Aug 24, 2022

Copy link
Copy Markdown
Contributor

Hiding it made it very difficult to figure out why versionner was
failing to figure out the version.

Closes #310

@yarikoptic
ENH: in verbose mode do not hide stderr of git rev-parse
8dcde6e 
Hiding it made it very difficult to figure out why versionner was
failing to figure out the version.

Closes python-versioneer#310
@effigies

effigies commented Aug 24, 2022

Copy link
Copy Markdown
Contributor

Should we add this to all runner() calls in this function?

@yarikoptic

yarikoptic commented Aug 24, 2022

Copy link
Copy Markdown
Contributor Author

Should we add this to all runner() calls in this function?

it seems that default is hide_stderr=False,

$> git grep 'def run_command'
src/git/from_vcs.py:def run_command(): pass  # --STRIP DURING BUILD
src/git/install.py:def run_command(): pass # --STRIP DURING BUILD
src/subprocess_helper.py:def run_command(commands, args, cwd=None, verbose=False, hide_stderr=False,

and there is no other overload to True so I do not see any other location to add this

$> git grep hide_stderr
src/git/from_vcs.py:                   hide_stderr=not verbose)
src/subprocess_helper.py:def run_command(commands, args, cwd=None, verbose=False, hide_stderr=False,
src/subprocess_helper.py:                                       stderr=(subprocess.PIPE if hide_stderr
test/git/test_git.py:                                 hide_stderr=False, env=None):

@effigies

effigies commented Aug 24, 2022

Copy link
Copy Markdown
Contributor

Sounds good.

@effigies effigies merged commit 408adeb into python-versioneer:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pass stderr in verbose mode from running git commands?

2 participants

@yarikoptic @effigies