You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks @abravalheri! This looks completely sensible. I think our existing guards in build_ext are probably already avoiding this case as well. It might be good to try to unify these to be more consistent between commands, but given that this seems to need fixing for many people on a short time scale, I'm inclined to merge and release.
Thank you very much @effigies. I also added some contingency to setuptools. Probably the later releases are much less problematic. Sorry if it caused any disruption.
It might be good to try to unify these to be more consistent between commands, but given that this seems to need fixing for many people on a short time scale, I'm inclined to merge and release.
In build_ext the inplace and the editable_mode attributes should work in unison with the new editable installs (they are pretty much exchangeable). I don't know if this helps to open the doors for some refactoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptoolsv64 introduces the new PEP 660 hooks, which seems to be incompatible withversioneer(as per pypa/setuptools#3501)The idea of this PR is to try finding a way to make the integration with the new version work properly.
Disclaimer: I am not very familiar with
python-versioneer, so please forgive me if there is something wrong here.Deep explanation
This means that when
pip install -e .runs, it will try to use the neweditable_wheelcommand instead ofdevelop.Previously, the
developcommand special-casedbuild_pyandbuild_extand treated each command considering the knowledge on what they do.This was problematic because custom build steps could not run during an editable install.
editable_wheeltries to use a more generic approach and fix the problem of custom build steps:buildsubcommands should run.For
versioneerthe implication is that thebuild_libdirectory may not contain a_version.pyfile.