FIX: skip version update on build_ext if .py does not exist#297
Merged
effigies merged 1 commit intoApr 26, 2022
Merged
Conversation
mgorny
force-pushed
the
build_py-before-build_ext
branch
from
a3a792c to
a394e75
Compare
mgorny
changed the title
build_py is called prior to build_extbuild_ext if .py does not exist
Contributor
|
@pkittenis Could I bug you for a review here, since you added the |
effigies
reviewed
Apr 26, 2022
effigies
left a comment
effigies
left a comment
Contributor
There was a problem hiding this comment.
In the absence of another review, I'll go ahead and merge, but can we make the message more explicit?
mgorny
force-pushed
the
build_py-before-build_ext
branch
from
0b23523 to
ec37649
Compare
Contributor
Author
|
Thanks, squashed that change into my commit. |
Contributor
Author
|
Hmm, I see I need to shorten the lines now. I'll do that in a minute. |
Contributor
|
Thanks. Sorry about that. |
Skip version update on `build_ext` command if the respective version file does not exist. This could be the case if `build_ext` is called explicitly without calling `build_py` prior to it. Closes python-versioneer#296
mgorny
force-pushed
the
build_py-before-build_ext
branch
from
ec37649 to
ff62f26
Compare
Contributor
Author
|
No problem. Pushed a fix now. |
effigies
approved these changes
Apr 26, 2022
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip version update on
build_extcommand if the respective versionfile does not exist. This could be the case if
build_extis calledexplicitly without calling
build_pyprior to it.Closes #296