Small change to domain RE#76
Merged
Merged
Conversation
Removing [.] from in the regex and added a non capturing group for it.
Added the following test case `a......b.com` to invalid domains.
Contributor
Author
|
@kvesteri not sure what I'm failing at, sorry. |
removed extra lines.
Contributor
Author
|
@kvesteri nvm 😄 |
Collaborator
|
Squash the commits, otherwise looks good. |
ghost
mentioned this pull request
Contributor
Author
|
@kvesteri How do I squash the commits on github =\ |
Collaborator
|
Thanks for the PR! 🌮 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #73
fixes #71
fixes #66