Repository navigation
Conversation
Added ASCII check for card number validation.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #567
Reject non-ASCII input before the Luhn check. Python's
int()accepts Unicode decimal digits, so fully Arabic-Indic/full-width card numbers, and mixed strings with an ASCII issuer prefix, currently pass validation.Adds 20 regression cases for fully non-ASCII input and mixed input across the generic validator and all eight card-brand helpers. Existing ASCII card numbers and invalid-checksum behavior stay unchanged.
Validation:
card_number()andvisa()directly with valid ASCII, invalid checksum, Arabic-Indic, full-width and mixed input.AI assistance was used for implementation and testing.