Added validator btc addresses on format P2PKH#166
Conversation
ghost
mentioned this pull request
Collaborator
|
@daveusa31 There are flake8 and isort errors. You can see the errors in the travis report. |
Author
|
I'm sorry, but I couldn't figure it out :( |
Collaborator
|
You can check the errors locally by first installing flake8 and isort The you can run the following command for isort: And for flake8 |
Author
|
Yeah, it works |
kvesteri
requested changes
Aug 17, 2020
|
|
||
|
|
||
| @validator | ||
| def btc_address(value): |
Collaborator
There was a problem hiding this comment.
Please add a doc block here defining how this function is to be used. See other functions of similar doc blocks. Also reference this doc block in the index.rst file
Author
|
Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. Please tell me what I did wrong?
Why doesn't travic-ci check?