between doesn't work with the number 0 #298

Activity

1. scotttyso commented on Sep 14, 2023

   

   scotttyso

   on Sep 14, 2023

   Author

   More actions

   For now I downgraded to validators to 0.11.0, which seems to be an old/different version of the module to work around this issue.
2. nandgator

   added

   bugIssue: Works not as designedIssue: Works not as designed

   on Sep 17, 2023
3. nandgator commented on Sep 17, 2023

   

   nandgator

   on Sep 17, 2023

   Collaborator

   More actions

   Nice catch! Here's a patch:

   diff --git a/src/validators/between.py b/src/validators/between.py
   index 77c9ae3..2fc3a0c 100644
   --- a/src/validators/between.py
   +++ b/src/validators/between.py
   @@ -8,7 +8,7 @@ from typing import TypeVar, Union
    from ._extremes import AbsMax, AbsMin
    from .utils import validator
    
   -PossibleValueTypes = TypeVar("PossibleValueTypes", int, float, str, datetime)
   +PossibleValueTypes = TypeVar("PossibleValueTypes", int, float, str, datetime, None)
    
    
    @validator
   @@ -67,7 +67,7 @@ def between(
    
        > *New in version 0.2.0*.
        """
   -    if not value:
   +    if value is None:
            return False
    
        if min_val is max_val is None:
   diff --git a/tests/test_between.py b/tests/test_between.py
   index 8e59ad6..6b1ccd7 100644
   --- a/tests/test_between.py
   +++ b/tests/test_between.py
   @@ -15,7 +15,7 @@ T = TypeVar("T", int, float, str, datetime)
    
    @pytest.mark.parametrize(
        ("value", "min_val", "max_val"),
   -    [(12, 11, 13), (12, None, 14), (12, 11, None), (12, 12, 12)],
   +    [(12, 11, 13), (12, None, 14), (12, 11, None), (12, 12, 12), (0, 0, 0), (0, -1, 3)],
    )
    def test_returns_true_on_valid_range(value: T, min_val: T, max_val: T):
        """Test returns true on valid range."""
   @@ -25,6 +25,7 @@ def test_returns_true_on_valid_range(value: T, min_val: T, max_val: T):
    @pytest.mark.parametrize(
        ("value", "min_val", "max_val"),
        [
   +        (None, 13, 14),
            (12, 13, 14),
            (12, None, 11),
            (12, None, None),

   PR is welcome!
4. nandgator

   added 2 commits that reference this issue on Sep 23, 2023

   fix: bug in `between` module

   ...

   This issue will close once commit 848b7dd is merged into the 'master' branch.

   848b7dd

   fix: bug in `between` module

   ...

   This issue will close once commit f7aa593 is merged into the 'master' branch.

   f7aa593
5. nandgator

   closed this as completedin #301on Sep 25, 2023