Repository navigation
Closed
Labels
developmentIssue/PR: Modification in workflows, packaging, etc.Issue/PR: Modification in workflows, packaging, etc.outdatedIssue/PR: Open for more than 3 monthsIssue/PR: Open for more than 3 months
Description
wheel archive generetaed by:
+ /usr/bin/python3 -sBm build -w --no-isolation
* Getting build dependencies for wheel...
* Building wheel...
Successfully built validators-0.21.1-py3-none-any.whlAnd it has content:
Archive: /home/tkloczko/rpmbuild/BUILD/validators-0.21.1/dist/validators-0.21.1-py3-none-any.whl
Length Method Size Cmpr Date Time CRC-32 Name
-------- ------ ------- ---- ---------- ----- -------- ----
9778 Defl:N 2891 70% 01-01-1980 00:00 f90038ec CHANGES.md
634 Defl:N 348 45% 01-01-1980 00:00 e31fc679 docs/Makefile
1697 Defl:N 592 65% 01-01-1980 00:00 d7e0f001 docs/conf.py
5467 Defl:N 1765 68% 01-01-1980 00:00 d7ca5c83 docs/gen_docs.py
1481 Defl:N 543 63% 01-01-1980 00:00 a780f003 docs/index.md
800 Defl:N 425 47% 01-01-1980 00:00 fd2f318a docs/make.bat
1404 Defl:N 574 59% 01-01-1980 00:00 dfde3183 validators/__init__.py
1124 Defl:N 372 67% 01-01-1980 00:00 a79a9866 validators/_extremes.py
3250 Defl:N 1075 67% 01-01-1980 00:00 9d2603cf validators/between.py
1739 Defl:N 861 51% 01-01-1980 00:00 e5be3933 validators/btc_address.py
6270 Defl:N 1047 83% 01-01-1980 00:00 2e8d6f7c validators/card.py
1814 Defl:N 789 57% 01-01-1980 00:00 154c3d33 validators/domain.py
2816 Defl:N 1054 63% 01-01-1980 00:00 3999e63a validators/email.py
3606 Defl:N 799 78% 01-01-1980 00:00 a8864406 validators/hashes.py
3706 Defl:N 1167 69% 01-01-1980 00:00 6c636cd5 validators/hostname.py
234 Defl:N 145 38% 01-01-1980 00:00 6f9da217 validators/i18n/__init__.py
5573 Defl:N 1652 70% 01-01-1980 00:00 9bec60a9 validators/i18n/es.py
3230 Defl:N 1228 62% 01-01-1980 00:00 378215f3 validators/i18n/fi.py
1146 Defl:N 575 50% 01-01-1980 00:00 16b63bdb validators/iban.py
3473 Defl:N 927 73% 01-01-1980 00:00 d8c72d36 validators/ip_address.py
1175 Defl:N 472 60% 01-01-1980 00:00 4009b667 validators/length.py
948 Defl:N 476 50% 01-01-1980 00:00 5710b0ff validators/mac_address.py
0 Defl:N 2 0% 01-01-1980 00:00 00000000 validators/py.typed
845 Defl:N 435 49% 01-01-1980 00:00 4ed6c11d validators/slug.py
6549 Defl:N 2184 67% 01-01-1980 00:00 112e6b3e validators/url.py
2392 Defl:N 896 63% 01-01-1980 00:00 7ca957f1 validators/utils.py
1147 Defl:N 553 52% 01-01-1980 00:00 fdd3c791 validators/uuid.py
1089 Defl:N 658 40% 01-01-1980 00:00 74fe0f1f validators-0.21.1.dist-info/LICENSE
2799 Defl:N 911 68% 01-01-1980 00:00 e1787640 validators-0.21.1.dist-info/METADATA
88 Defl:N 86 2% 01-01-1980 00:00 5f07d630 validators-0.21.1.dist-info/WHEEL
2355 Defl:N 1405 40% 01-01-2016 00:00 5fd0d275 validators-0.21.1.dist-info/RECORD
-------- ------- --- -------
78629 26907 66% 31 filesLooks like MANIFEST.in files needs to be aded
Metadata
Metadata
Assignees
Labels
developmentIssue/PR: Modification in workflows, packaging, etc.Issue/PR: Modification in workflows, packaging, etc.outdatedIssue/PR: Open for more than 3 monthsIssue/PR: Open for more than 3 months
Activity
nandgator commentedon Apr 26, 2023
Hi @kloczek, what do you mean by
pep517 build packages docs/ content?If you build package using
python build_pkg.pythese are the contents ofvalidators-0.21.1-py3-none-any.whl:nandgator commentedon Apr 26, 2023
These were the content of MANIFEST.in:
Commit 6bd8751, overrides it with the configuration in
pyproject.toml:validators/pyproject.toml
Line 43 in 506d22b
Do you want to include these in
pyproject.tomlinstead:kloczek commentedon Apr 26, 2023
Please try to build .whl archove using
python3 -sBm build -w --no-isolationcommand.This meand that those files will be included in .whl archive an dinstalled on use
pipor installermodule.Here is the patch against 0.21.1
nandgator commentedon Apr 26, 2023
Why?
I do not see where in PEP 517, that command is recommended.
It requires me to install
build.You could instead, simply run
python build_pkg.pywhich in turn runspoetry build.validators/py.typedgets automatically included, why remove others from.whl?kloczek commentedon Apr 26, 2023
Becauseuse pep517 build executed that way will look always the same doesn't matter which one pep517 bakednd will be used.
Yes 'build` is not part of the base putone modules and needs to be installed.
Please try to install that .whl using
piporinstallermodule in some </install/prefix> and than check you will se why.pep517 is new build procddure.
buildprovudes the same command to execute does't matter which one backend is used (in your case it isseruptools).kloczek commentedon Apr 26, 2023
https://peps.python.org/pep-0517/
nandgator commentedon Apr 26, 2023
My build backed is
poetrynotsetuptools.validators/pyproject.toml
Lines 9 to 13 in 506d22b
I commented out the following in
pyproject.toml:# include = ["README.md", "LICENSE", "CHANGES.md", "docs/*", "tests/*"]Then I did, but what am I looking for?
If so, then why not use
poetry build?PEP 517 is a specification that decouples frontends and backends in Python packaging. You can refer this talk
What does PEP 517 mean for packaging. The goal was to "dethrone distutils and setuptools as the single blessed way of making Python packages."
On another note, you're typing like an email spammer.
kloczek commentedon Apr 26, 2023
There are two possibilies of include/exclude.
One includes/excludes from sdist and whl, and second one only include/exclude from whl.
This one causes that those files are included in whl as well.
Into destdir passed as param for
piporinstaller.Which one
pipversion you are using?Can you try to use it without venv and execurte pip with
--dest /tmp/fooand check what is inside?Because in exact case you need to know first that exct module uses for example
poetryas pep517 backend.With
buildyou can execute exacly the same command for setuptools, poetry, whey, hatch, hatclings, setuptools-scm, pdm and few other already available.What you mean? 😋
nandgator commentedon Apr 27, 2023
Are you looking for this?
ref: https://python-poetry.org/docs/pyproject#include-and-exclude
sdist contentswhl contentsnandgator commentedon Aug 7, 2023
Fixed in #283