Skip to content

Domain validator now too permissive #123

@leforestier

Description

@leforestier

Hello,

It seems any string composed of numbers separated by dots is now accepted by the domain validator.

>>> validators.domain("123.123")
True

>>> validators.domain("123.123.123")
True

>>> validators.domain("123.123.123.123")
True

It didn't use to be the case (I know because it now causes some errors in my unit tests in the "naval" library)
I think it was good that these strings weren't accepted as domains. I don't think these are valid domains.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions