fix trio100 removing trailing comment with same-line with#186
Merged
Zac-HD merged 1 commit intopython-trio:mainfrom May 1, 2023
Merged
Conversation
jakkdl
force-pushed
the
autofix_100_same_line_eating_comments
branch
from
847874a to
ec5f15a
Compare
Member
Author
|
thought it'd be trickier than this, but past me had written good code and libcst is nice |
Zac-HD
approved these changes
May 1, 2023
Member
Zac-HD
left a comment
Zac-HD
left a comment
There was a problem hiding this comment.
Wow, that's even nicer than I expected from your comment 🤩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added basic test case showing the problem, this was the cause of my confusion in #182 with comments disappearing.
todo: write a fix