Skip to content

Fix race condition in dispatcher start/stop #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tsnoam merged 3 commits into from
Oct 21, 2017
Merged

Fix race condition in dispatcher start/stop #887

tsnoam merged 3 commits into from
Oct 21, 2017

Conversation

@tsnoam
Copy link
Member

@tsnoam tsnoam commented Oct 21, 2017

Fixes #881

jsmnbom
jsmnbom approved these changes Oct 21, 2017
View reviewed changes
Copy link
Member

@jsmnbom jsmnbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems like a simple fix.
Can we test it?

jh0ker
jh0ker reviewed Oct 21, 2017
View reviewed changes
telegram/ext/dispatcher.py
dispatcher is ready.
"""
if self.running:
Copy link
Member

@jh0ker jh0ker Oct 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we do ready.set() here as well?

Copy link
Member Author

@tsnoam tsnoam Oct 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense. i'll fix.

@codecov
Copy link

codecov bot commented Oct 21, 2017 •
edited
Loading

Codecov Report

Merging #887 into master will decrease coverage by 0.18%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #887      +/-   ##
=========================================
- Coverage   91.89%   91.7%   -0.19%     
=========================================
  Files         101     101              
  Lines        4057    4063       +6     
  Branches      621     623       +2     
=========================================
- Hits         3728    3726       -2     
- Misses        194     198       +4     
- Partials      135     139       +4
Flag Coverage Δ
#Appveyor 86.85% <75%> (-0.03%) ⬇️
#Travis 91.28% <75%> (-0.19%) ⬇️
Impacted Files Coverage Δ
telegram/ext/updater.py 76.92% <100%> (+0.25%) ⬆️
telegram/ext/dispatcher.py 91.81% <60%> (-1.01%) ⬇️
telegram/message.py 96.22% <0%> (-0.76%) ⬇️
telegram/bot.py 87.22% <0%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed0599...086f1b8. Read the comment docs.

jh0ker
jh0ker approved these changes Oct 21, 2017
View reviewed changes
Copy link
Member

@jh0ker jh0ker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it :)

@tsnoam
Copy link
Member Author

tsnoam commented Oct 21, 2017 •
edited
Loading

@bomjacob I don't think that we can properly test it.
We can pass an Event object to dispatcher.start() but what will it tell us? Only that we've called set() on the Event. It won't guarantee that it had been done properly.
So basically, I don't think that testing this is worth the effort.

Edit: properly = in proper order

@tsnoam tsnoam merged commit 4b3315d into master Oct 21, 2017
@tsnoam tsnoam deleted the fix_881 branch October 21, 2017 11:40
This was referenced Dec 8, 2017
Merged
Merged
@pyup-bot pyup-bot mentioned this pull request Jan 22, 2018
Closed
This was referenced Mar 2, 2018
Closed
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jsmnbom jsmnbom jsmnbom approved these changes

@jh0ker jh0ker jh0ker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Race condition in Dispatcher.start/stop()

4 participants

@tsnoam @jsmnbom @jh0ker