Stabilize Coverage #846
Merged
Stabilize Coverage #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
==========================================
+ Coverage 91.77% 91.79% +0.02%
==========================================
Files 101 101
Lines 4023 3987 -36
Branches 614 603 -11
==========================================
- Hits 3692 3660 -32
+ Misses 191 189 -2
+ Partials 140 138 -2
Continue to review full report at Codecov.
|
Member
|
Is it possible to run it a few times to test or will we just have to wait and see? |
Member
Author
|
@bomjacob What it does is: run tests for all exceptions and remove coverage evaluation for code that is reliant on an error or other exception that do not always occur. Problem now is that project coverage fluctuates with every build for master, depending on if this coffee runs or not. I hope to eliminate that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage reports can flutuate because in one build for the project error's are fired while in another build they're not. This makes for weird minimal increase/decreases.
I tried to stabelize this by adding a test for all exceptions we made and ignoring some other lines for coverage.