Skip to content

Conversation

@jeffffc
Copy link
Contributor

@jeffffc jeffffc commented Sep 25, 2017

Fix Job Class missing from the docs
and fix the docstring at Job class that failed to link JobQueue
preview at: http://ptb.readthedocs.io/en/docs-fix4/

duplicated with #843, closing it

@codecov
Copy link

codecov bot commented Sep 25, 2017

Codecov Report

Merging #845 into master will decrease coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #845     +/-   ##
=========================================
- Coverage   91.77%   91.27%   -0.5%     
=========================================
  Files         101      101             
  Lines        4023     4023             
  Branches      614      614             
=========================================
- Hits         3692     3672     -20     
- Misses        191      208     +17     
- Partials      140      143      +3
Flag Coverage Δ
#Appveyor 86.35% <ø> (ø) ⬆️
#Travis 90.9% <ø> (-0.5%) ⬇️
Impacted Files Coverage Δ
telegram/ext/jobqueue.py 91.89% <ø> (ø) ⬆️
telegram/error.py 86.48% <0%> (-5.41%) ⬇️
telegram/utils/request.py 63.7% <0%> (-4.04%) ⬇️
telegram/ext/updater.py 74.01% <0%> (-3.44%) ⬇️
telegram/message.py 96.01% <0%> (-0.8%) ⬇️
telegram/bot.py 87.46% <0%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5614af1...1f893d6. Read the comment docs.

@Eldinnie
Copy link
Member

Oops, thanks.
It seems codecov is a bit too strict in some places. LGTM

@Eldinnie Eldinnie added the 📋 pending-merge work status: pending-merge label Sep 25, 2017
@Eldinnie
Copy link
Member

Again, thanks for contributing @jeffffc

@Eldinnie Eldinnie merged commit dbb3b16 into python-telegram-bot:master Sep 25, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

📋 pending-merge work status: pending-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants