Codecov Report

Merging #832 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
- Coverage   91.27%   91.25%   -0.03%     
==========================================
  Files         101      101              
  Lines        4023     4023              
  Branches      614      614              
==========================================
- Hits         3672     3671       -1     
  Misses        208      208              
- Partials      143      144       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd20237...fd54e59. Read the comment docs.

To me it would be unintuitive to suddenly receive edited_channel_posts in my MessageHandler(..., allow_edited=False) without having channel_post_updates=True too, but that might just be me?

@bomjacob hmm, that's also True. What do you suggest? Although allow_edited is being deprecated. Do you feel the same for edited_updates?

Yeah sorry that's what I meant. But looking at it now, that might turn out to me unintuitive behaviour since currently edited_updates doesn't require message_updates to be true for a edited_message to be allowed through. So I don't really know... This is just yet another reason for considering refractoring the filter system to handle these things.

@bomjacob that is definitely True. But for now I see no way to fix it (without breaking backwards compatibility) other then introducing edited_channel_post_updates as a marker.

Hmm, that would be okay if edited_updates was called edit_message_updates but it's not... So I think for now that the change you've made already in the PR might be the best we can do while maintaining backwards compat and not confusing users too much.