Added utils.helpers.effective_message_type #826
Conversation
…of message as a string from an update or message.
…of message as a string from an update or message.
|
I rebased on master. Two things I would like to see on this. |
Eldinnie
left a comment
Eldinnie
left a comment
There was a problem hiding this comment.
Tests for all occurencies (no type, and an update passed instead of a message)
And please revert the param line in test_message
|
@JosXa what is the status for this? |
|
@Eldinnie I don't have much time atm. Hope to get to all my open issues end of the week |
|
@JosXa 👍 |
|
Made changes as requested. Question remains: Can/should we do something about the cyclic import (see |
# Conflicts: # telegram/utils/helpers.py
|
Integration tests fail because of flood timeouts etc. PR lgtm. |
Codecov Report
@@ Coverage Diff @@
## master #826 +/- ##
==========================================
- Coverage 91.83% 91.64% -0.19%
==========================================
Files 103 103
Lines 4052 4070 +18
Branches 639 645 +6
==========================================
+ Hits 3721 3730 +9
- Misses 193 198 +5
- Partials 138 142 +4
|
|
Coverage is not 100% because this case is never tested: |
Bibo-Joshi
added
🔌 enhancement
I've added a TODO tag in the helpers file where cyclic imports would happen if I didn't put the import statements inside of the method. This should be fixed before merging.