Enable appveyor #823
Enable appveyor #823
Conversation
Codecov Report
@@ Coverage Diff @@
## master #823 +/- ##
==========================================
+ Coverage 91.07% 91.27% +0.19%
==========================================
Files 101 101
Lines 4023 4023
Branches 614 614
==========================================
+ Hits 3664 3672 +8
- Misses 206 208 +2
+ Partials 153 143 -10
Continue to review full report at Codecov.
|
tests/test_meta.py
Outdated
| @pytest.mark.nocoverage | ||
| @pytest.mark.parametrize('hook_id', argvalues=('yapf', 'flake8', 'pylint')) | ||
| @pytest.mark.skipif(not os.getenv('TRAVIS'), reason='Not running in travis.') | ||
| @pytest.mark.skipif(not (os.getenv('TRAVIS') or os.getenv('APPVEYOR')), reason='Not running in travis.') |
tests/test_bot.py
Outdated
| assert chat_member.status == 'administrator' | ||
| assert chat_member.user.username == 'EchteEldin' | ||
|
|
||
| @pytest.mark.skipif(os.getenv('APPVEYOR'), reason='Skip game tests on Appveyor') |
There was a problem hiding this comment.
Maybe we should write why we're skipping and not just that we are in the reason?
(I know we haven't really done this before but it makes more sense to do it like that I think)
(applies elsewhere)
|
Mostly looks good! Good call on just doing it instead of waiting for us to set up more bots. Also it looks like the build is failing? Due to timing differences among other issues? (I don't really understand how to read this) |
appveyor is terrible at precise timings.
|
So, As far as I'm concerned this is the first step towards adding Appveyor to our CI cycle. For now I'm skipping tests for telegram-communication regarding stickers and games because they're not added on the bot (yet). Coverage increased because now the branches that split for windows and posix systems now both are executed. I addressed @bomjacob 's review comments. |
|
closes #591 |
I made a new bot in my account and hid the relevant information in appveyors environment vars.
I modified appveyor.yaml to use the new tests and codecov.
If all is well this should mean I've enabled appveyor