Skip to content

Show what parameter/attribute is missing in test_offical #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eldinnie merged 2 commits into from
Sep 1, 2017
+4 −3
Merged

Show what parameter/attribute is missing in test_offical #808

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a772977
Show what parameter/attribute is missing in test_offical
Eldinnie Aug 23, 2017
0134d32
Only run test_official on py3.6
Eldinnie Aug 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/test_official.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ def check_method(h4):
checked = []
for parameter in table:
param = sig.parameters.get(parameter.Parameters)
assert param is not None
assert param is not None, "Parameter {} not found in {}".format(parameter.Parameters,
method.__name__)
# TODO: Check type via docstring
# TODO: Check if optional or required
checked.append(parameter.Parameters)
Expand Down Expand Up @@ -106,7 +107,7 @@ def check_object(h4):
continue

param = sig.parameters.get(field)
assert param is not None
assert param is not None, "Attribute {} not found in {}".format(field, obj.__name__)
# TODO: Check type via docstring
# TODO: Check if optional or required
checked.append(field)
Expand Down Expand Up @@ -149,7 +150,7 @@ def check_object(h4):


@pytest.mark.parametrize(('method', 'data'), argvalues=argvalues, ids=names)
@pytest.mark.skipif(not sys.version_info >= (3, 5) or python_implementation() != 'CPython',
@pytest.mark.skipif(not sys.version_info >= (3, 6) or python_implementation() != 'CPython',
reason='follow_wrapped (inspect.signature) is not supported on this platform')
def test_official(method, data):
method(data)