remove de_json() #789
Merged
remove de_json() #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eldinnie
force-pushed
the
remove_de_json
branch
from
6ff70eb to
05ca4fe
Compare
Member
Author
|
tests passed. review wanted |
jsmnbom
requested changes
Aug 12, 2017
Member
jsmnbom
left a comment
jsmnbom
left a comment
There was a problem hiding this comment.
Looks good to me, I think you got all the classes. Left two very minor comments though.
| input_text_message_content_json = InputMessageContent.de_json(json_dict, bot) | ||
|
|
||
| assert input_text_message_content_json is None | ||
| def test_exspected_values(self, input_text_message_content): |
| def input_location_message_content(): | ||
| return InputLocationMessageContent(TestInputLocationMessageContent.longitude, | ||
| TestInputLocationMessageContent.latitude) | ||
| return InputLocationMessageContent(longitude=TestInputLocationMessageContent.longitude, |
Member
There was a problem hiding this comment.
Why did you add these as kwargs?
Throughout the rest of the test we pass as an arg if it's a arg and kwarg if kwarg.
Member
Author
There was a problem hiding this comment.
because they were in the wrong order and adding kwargs was lazier then reversing the order. Will fix though
Member
Author
|
@bomjacob I addressed your review changes. |
jsmnbom
approved these changes
Aug 12, 2017
This was referenced Mar 2, 2018
Bibo-Joshi
added
🔌 enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unneeded and unused de_json and de_list methods from our library. The only usages for these methods in our lib were within each other's de_json methods and our tests.
Expect Travis to fail, let it run again when #788 is merged.
Fixes #778