bot.py fixes discoverd while testing #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offset for get_user_profile_photo can be zero. edit_message_caption should raise ValueError in compliance with other methods. Also changed to snake_case edit_message_reply_markup was even weirder
Member
|
Not sure what you mean by "edit_message_reply_markup was even weirder", to me it looks to have been as weird as "edit_message_caption" ? |
Member
Author
|
Exactly, it mentions editMessageCaption in the ValueError (instead of edit_message_reply_markup) |
Member
|
Oh I see what you mean now ^^ |
jsmnbom
approved these changes
Aug 7, 2017
Member
jsmnbom
left a comment
jsmnbom
left a comment
There was a problem hiding this comment.
Should limit also be "if limit is not None: " or is that not necessary since you'd never want to send a 0?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offset for get_user_profile_photo can be zero.
edit_message_caption should raise ValueError in compliance with other methods. Also changed to snake_case
edit_message_reply_markup was even weirder