send_* now accepts tg-objects #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audio Contact, Document Location Photo Sticker Venue Video VideoNote Voice Docstring check updating sticker arguments Changelog
Member
Author
|
fixes #731 |
Merged
As per Request by @tsnoam
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the functionality suggested by @bomjacob to pass an object to the relevant send_* method.
For example send_video not accepts either a string, file or telegram.Video object (in which case it will use it;s file_id).
I also added this for send_location, _venue and _contact which means I added an extra parameter to those methods (in the end) and raise a
TypeErrorwhen the required arguments nor the object parameter is given.added tests for these new feature and adjusted the test_official to ignore the added parameters.
Lastly I noticed the TG-docs have updated the
MaskPositionby renamingzoomtoscale. I also updated this.