TelegramObject.de_json became classmethod closes #734 #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
As you can see in the tests, they fail for python 2.7 (ignore the webhook timeout. And can you explain why this would be an improvement over static methods? |
Calling super(ClassName, cls).de_json fix to make it work in python 2.7
Member
|
They are an improvement since they make subclassing of our objects possible without necessarily needing to overwrite the de_json method |
Contributor
Author
|
Errors fixed. Take a look at my explanation here, please: #734 |
Member
|
I was just wondering why it would make a difference. But seeing that tests keep up. I think it's fine. |
Eldinnie
approved these changes
Jul 23, 2017
Member
|
@ihoru |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.